Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Copy] developer guide en edition #8724

Merged
merged 23 commits into from
May 26, 2022
Merged

[Copy] developer guide en edition #8724

merged 23 commits into from
May 26, 2022

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented May 25, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/no-need No need to translate this PR. area/develop This PR relates to the area of TiDB App development. labels May 25, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 25, 2022
@Icemap Icemap marked this pull request as ready for review May 25, 2022 07:10
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 25, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 25, 2022 07:10
@Icemap
Copy link
Member Author

Icemap commented May 25, 2022

/cc @qiancai

@ti-chi-bot ti-chi-bot requested a review from qiancai May 25, 2022 07:11
@Oreoxmt Oreoxmt self-requested a review May 25, 2022 07:54
Oreoxmt
Oreoxmt reviewed May 25, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
Cheese and others added 2 commits May 25, 2022 16:03
@Oreoxmt
Update develop/dev-guide-unique-serial-number-generation.md
6114eb3 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
83fd218 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed May 25, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
Cheese and others added 10 commits May 25, 2022 16:34
@Oreoxmt
Update TOC.md
9076409 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
32d2695 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
82c3a5f 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
067f610 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
594898b 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
eeb2339 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
351b562 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
9174a6f 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
6203a2f 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Update TOC.md
e2f65de 
Co-authored-by: Aolin <aolinz@outlook.com>
@Icemap
Copy link
Member Author

Icemap commented May 25, 2022

synchronized to #8735

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
qiancai
qiancai reviewed May 25, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
Icemap and others added 4 commits May 25, 2022 23:16
@Icemap
[Update] TOC sync to chinese
e5d471f
@qiancai
Update TOC.md
b32358b 
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai
Update TOC.md
bc740b2 
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai
Update TOC.md
9e789ed 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Icemap
Copy link
Member Author

Icemap commented May 25, 2022

synchronized to #8735

qiancai
qiancai reviewed May 26, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@qiancai
Copy link
Collaborator

qiancai commented May 26, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c9801b8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@ti-chi-bot ti-chi-bot merged commit 4190d68 into master May 26, 2022
@shichun-0415 shichun-0415 deleted the developer-copy branch February 2, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
area/develop This PR relates to the area of TiDB App development. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Icemap @ti-chi-bot @qiancai @Oreoxmt