Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mydumper tikv importer #15289

Merged

Conversation

Frank945946
Copy link
Contributor

@Frank945946 Frank945946 commented Nov 7, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Deprecate mydumper tikv importer

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Oreoxmt and others added 7 commits October 19, 2023 16:04
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2023
@Oreoxmt Oreoxmt mentioned this pull request Nov 7, 2023
19 tasks
@Oreoxmt Oreoxmt self-assigned this Nov 7, 2023
@Oreoxmt Oreoxmt added v7.5 This PR/issue applies to TiDB v7.5. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed area/develop This PR relates to the area of TiDB App development. labels Nov 7, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 7, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 7, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang November 7, 2023 09:46
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2023
Copy link

ti-chi-bot bot commented Nov 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-07 09:46:45.703368098 +0000 UTC m=+3551203.290478228: ☑️ agreed by Oreoxmt.
  • 2023-11-07 09:51:31.330520363 +0000 UTC m=+3551488.917630508: ☑️ agreed by ran-huang.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 13, 2023

/approve

Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit c5883de into pingcap:master Nov 13, 2023
11 checks passed
Oreoxmt pushed a commit to Oreoxmt/docs that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.5 This PR/issue applies to TiDB v7.5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants