Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Mydumper and tikv-importer #15135

Closed
wants to merge 7 commits into from
Closed

remove Mydumper and tikv-importer #15135

wants to merge 7 commits into from

Conversation

Frank945946
Copy link
Contributor

@Frank945946 Frank945946 commented Oct 19, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Starting from v7.5.0, Mydumper and tikv-importer are deprecated.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2023
@Oreoxmt Oreoxmt requested review from D3Hunter and lichunzhu October 19, 2023 07:28
@Oreoxmt Oreoxmt self-assigned this Oct 19, 2023
@Oreoxmt Oreoxmt added the translation/doing This PR's assignee is translating this PR. label Oct 19, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 19, 2023
@Oreoxmt Oreoxmt added the v7.5 This PR/issue applies to TiDB v7.5. label Oct 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Oreoxmt
deprecate Mydumper and tikv-importer
dbec172 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt
Oreoxmt reviewed Oct 19, 2023
View reviewed changes
dm/dm-error-handling.md Outdated Show resolved Hide resolved
Frank945946
Frank945946 commented Oct 19, 2023
View reviewed changes
dumpling-overview.md Show resolved Hide resolved
ecosystem-tool-user-guide.md Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-mysql.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-configuration.md Outdated Show resolved Hide resolved
dm/dm-error-handling.md Outdated Show resolved Hide resolved
Oreoxmt and others added 4 commits October 19, 2023 16:45
@Oreoxmt
Discard changes to dm/dm-error-handling.md
6b0a6b7
@Oreoxmt @Frank945946
Apply suggestions from code review
98a618a 
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
@Oreoxmt
make ci happy
68c6a16 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt
update the restart FAQ
0394311 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt requested a review from Benjamin2037 October 25, 2023 07:58
D3Hunter
D3Hunter approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tikv-importer part lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

tikv-importer part lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lichunzhu
lichunzhu approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mydumper part LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 26, 2023
@Oreoxmt
refine wording
6d78572 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt removed the translation/doing This PR's assignee is translating this PR. label Oct 26, 2023
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Oct 26, 2023
@Oreoxmt Oreoxmt mentioned this pull request Oct 26, 2023
Merged
19 tasks
@Oreoxmt Oreoxmt requested a review from ran-huang October 27, 2023 06:42
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-26 03:13:29.42656173 +0000 UTC m=+2490807.013671872: ☑️ agreed by lichunzhu.
  • 2023-10-30 07:44:36.133782351 +0000 UTC m=+2852673.720892495: ☑️ agreed by ran-huang.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 7, 2023

Close by #15289

@Oreoxmt Oreoxmt closed this Nov 7, 2023
@Oreoxmt Oreoxmt mentioned this pull request Nov 7, 2023
Merged
17 tasks
@Oreoxmt Oreoxmt removed the v7.5 This PR/issue applies to TiDB v7.5. label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt left review comments

@ran-huang ran-huang ran-huang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees

@Oreoxmt Oreoxmt

Labels
area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Frank945946 @Oreoxmt @D3Hunter @lichunzhu @ran-huang