Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: Cleanup typo in feature-online-ddl and update dm-faq #14481

Merged
merged 3 commits into from
Sep 21, 2023
Merged

dm: Cleanup typo in feature-online-ddl and update dm-faq #14481

merged 3 commits into from
Sep 21, 2023

Conversation

hongshaoyang
Copy link
Contributor

@hongshaoyang hongshaoyang commented Aug 10, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Cleanup typo in feature-online-ddl
  • Remove obsolete config online-ddl-scheme and replace with existing config online-ddl

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Aug 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

Welcome @hongshaoyang!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@hongshaoyang hongshaoyang changed the title Cleanup headings and typo in feature-online-ddl.md Cleanup typo in feature-online-ddl and update dm-fq Aug 10, 2023
@hongshaoyang hongshaoyang changed the title Cleanup typo in feature-online-ddl and update dm-fq Cleanup typo in feature-online-ddl and update dm-faq Sep 11, 2023
@hongshaoyang hongshaoyang changed the title Cleanup typo in feature-online-ddl and update dm-faq dm: Cleanup typo in feature-online-ddl and update dm-faq Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot requested review from Oreoxmt and ran-huang September 11, 2023 08:32
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 06:47:58.675585277 +0000 UTC m=+251860.600141672: ☑️ agreed by lance6716.
  • 2023-09-11 09:09:46.69199794 +0000 UTC m=+260368.616554346: ☑️ agreed by ran-huang.

@ran-huang ran-huang self-assigned this Sep 11, 2023
@ran-huang ran-huang added the translation/doing This PR's assignee is translating this PR. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 11, 2023
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 11, 2023
@ran-huang
Copy link
Contributor

/rebase

@ran-huang ran-huang closed this Sep 11, 2023
@ran-huang ran-huang reopened this Sep 11, 2023
@qiancai qiancai force-pushed the hongshaoyang-patch-1 branch from aa6ee30 to 93def4e Compare September 11, 2023 09:31
@hongshaoyang
Copy link
Contributor Author

What's missing from this PR from automatic merging? Is it tidb-check and tidbcloud-check?

@ran-huang
Copy link
Contributor

What's missing from this PR from automatic merging? Is it tidb-check and tidbcloud-check?

@hongshaoyang yes. You need approval from a user with write permission to run the check. I have just approved the run and this PR will be merged soon.

@ti-chi-bot ti-chi-bot bot merged commit d62ac67 into pingcap:master Sep 21, 2023
@hongshaoyang hongshaoyang deleted the hongshaoyang-patch-1 branch September 22, 2023 09:08
@ran-huang ran-huang mentioned this pull request Nov 27, 2023
Merged
6 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@lance6716 lance6716 lance6716 approved these changes

@Frank945946 Frank945946 Awaiting requested review from Frank945946

@Oreoxmt Oreoxmt Awaiting requested review from Oreoxmt

Assignees

@ran-huang ran-huang

Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongshaoyang @ran-huang @lance6716