Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MySQL Connector/Python example add some log to give some instructions #14242

Merged
merged 2 commits into from
Jul 17, 2023
Merged

feat: MySQL Connector/Python example add some log to give some instructions #14242

merged 2 commits into from
Jul 17, 2023

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Jul 17, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update the code of mysql_connector_python_example.py to keep it consistent with pingcap-inc/tidb-example-python#1.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
@Icemap Icemap added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 17, 2023
@Icemap Icemap requested a review from Oreoxmt July 17, 2023 06:47
@Icemap
Copy link
Member Author

Icemap commented Jul 17, 2023

/cc @wd0517

@ti-chi-bot ti-chi-bot bot requested a review from wd0517 July 17, 2023 07:01
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

@wd0517: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 17, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang July 17, 2023 09:05
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-17 07:36:05.458173838 +0000 UTC m=+922257.228512552: ☑️ agreed by Oreoxmt.
  • 2023-07-17 10:41:18.098745507 +0000 UTC m=+933369.869084219: ☑️ agreed by ran-huang.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 17, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit c65928a into pingcap:master Jul 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2023
Closed
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #14248.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 17, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#14242
88e5ae7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/docs#release-6.5 from head ti-chi-bot:cherry-pick-14242-to-release-6.5: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14251.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14252.

This was referenced Jul 17, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14253.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2023
@ti-chi-bot
feat: MySQL Connector/Python example add some log to give some instru…
38b351f 
…ctions (#14242) (#14251)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2023
@ti-chi-bot
feat: MySQL Connector/Python example add some log to give some instru…
094115b 
…ctions (#14242) (#14253)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2023
@ti-chi-bot
feat: MySQL Connector/Python example add some log to give some instru…
e6ab399 
…ctions (#14242) (#14252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@ran-huang ran-huang ran-huang approved these changes

@wd0517 wd0517 wd0517 approved these changes

Assignees
No one assigned
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Icemap @Oreoxmt @ti-chi-bot @wd0517 @ran-huang