Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev guide: use SimpleTab to describe two MySQL clients #12469

Merged
merged 1 commit into from
Feb 22, 2023
Merged

dev guide: use SimpleTab to describe two MySQL clients #12469

merged 1 commit into from
Feb 22, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 13, 2023

Signed-off-by: Aolin aolin.zhang@pingcap.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Preview:
image

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt
dev guide: use SimpleTab to describe two MySQL clients
56db642 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 13, 2023
@Oreoxmt Oreoxmt requested a review from Icemap February 13, 2023 11:27
@Oreoxmt Oreoxmt self-assigned this Feb 13, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2023
@Oreoxmt Oreoxmt requested a review from shichun-0415 February 21, 2023 13:34
shichun-0415
shichun-0415 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2023
@Oreoxmt Oreoxmt added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 22, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 22, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 56db642

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2023
@ti-chi-bot ti-chi-bot merged commit abcf40f into pingcap:master Feb 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12621.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #12622.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12623.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12624.

ti-chi-bot added a commit that referenced this pull request Feb 22, 2023
@ti-chi-bot
dev guide: use SimpleTab to describe two MySQL clients (#12469) (#12622)
c53f4c7
ti-chi-bot added a commit that referenced this pull request Feb 22, 2023
@ti-chi-bot
dev guide: use SimpleTab to describe two MySQL clients (#12469) (#12624)
0323178
ti-chi-bot added a commit that referenced this pull request Feb 22, 2023
@ti-chi-bot
dev guide: use SimpleTab to describe two MySQL clients (#12469) (#12621)
e86a7e4
ti-chi-bot added a commit that referenced this pull request Feb 22, 2023
@ti-chi-bot
dev guide: use SimpleTab to describe two MySQL clients (#12469) (#12623)
6cfad1d
@Oreoxmt Oreoxmt deleted the translate/docs-12987 branch February 27, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@Icemap Icemap Awaiting requested review from Icemap

Assignees

@Oreoxmt Oreoxmt

Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oreoxmt @ti-chi-bot @shichun-0415