Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PingCAP Education Update Sub-domain #12407

Merged
merged 2 commits into from
Feb 8, 2023
Merged

PingCAP Education Update Sub-domain #12407

merged 2 commits into from
Feb 8, 2023

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Feb 8, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update the link of PingCAP Education from https://freeclasses.edu.pingcap.com to https://eng.edu.pingcap.com

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from ran-huang February 8, 2023 02:47
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2023
@Icemap Icemap added translation/no-need No need to translate this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2023
@Icemap
Copy link
Member Author

Icemap commented Feb 8, 2023

/cc @Soline324 @Oreoxmt

@ti-chi-bot ti-chi-bot requested a review from Oreoxmt February 8, 2023 02:49
@ti-chi-bot
Copy link
Member

@Icemap: GitHub didn't allow me to request PR reviews from the following users: Soline324.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Soline324 @Oreoxmt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Icemap Icemap removed the request for review from ran-huang February 8, 2023 02:49
Soline324
Soline324 reviewed Feb 8, 2023
View reviewed changes
Copy link

@Soline324 Soline324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update. Besides, the course name should also be updated from"TiDB Architecture Basics" to "Introduction to TiDB". @Icemap

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2023
Oreoxmt
Oreoxmt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
@Oreoxmt Oreoxmt requested a review from Soline324 February 8, 2023 05:02
Soline324
Soline324 approved these changes Feb 8, 2023
View reviewed changes
Copy link

@Soline324 Soline324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 8, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 023393d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@Icemap Icemap merged commit 20f3b03 into pingcap:master Feb 8, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 8, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12409.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12410.

This was referenced Feb 8, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12411.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 8, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #12412.

ti-chi-bot added a commit that referenced this pull request Feb 8, 2023
@ti-chi-bot
PingCAP Education Update Sub-domain (#12407) (#12410)
bf99e94
ti-chi-bot added a commit that referenced this pull request Feb 8, 2023
@ti-chi-bot
PingCAP Education Update Sub-domain (#12407) (#12411)
a19f75e
ti-chi-bot added a commit that referenced this pull request Feb 8, 2023
@ti-chi-bot
PingCAP Education Update Sub-domain (#12407) (#12412)
edd33fe
ti-chi-bot added a commit that referenced this pull request Feb 8, 2023
@ti-chi-bot
PingCAP Education Update Sub-domain (#12407) (#12409)
efc2470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@Soline324 Soline324 Soline324 approved these changes

Assignees
No one assigned
Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Icemap @ti-chi-bot @Oreoxmt @Soline324