Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to yarn v3 #545

Merged
merged 5 commits into from
Aug 10, 2021
Merged

upgrade to yarn v3 #545

merged 5 commits into from
Aug 10, 2021

Conversation

sachinraja
Copy link
Contributor

@sachinraja sachinraja commented Jul 31, 2021

Noticed this package was still using yarn v1. This PR updates it to yarn v3. I had to delete a lot of package.json files from the fixtures because they confused yarn when it attempted to find the package root. It resolves tsc from there anyway (before a script explicitly linking to the bin was used).

@piglovesyou
Copy link
Owner

This is so nice, thank you @sachinraja. Removing all the package.json files make it so clean.

I'm still unfamiliar with Yarn v3, could you take a look at the CI failure? I confirmed it passes all tests locally.

@sachinraja
Copy link
Contributor Author

Seems to be the same error as yarnpkg/berry#3191, I'll see if setting the version from sources fixes it.

@sachinraja
Copy link
Contributor Author

sachinraja commented Aug 9, 2021

This should pass now if the workflow is re-run

@piglovesyou piglovesyou merged commit ae00918 into piglovesyou:main Aug 10, 2021
@piglovesyou
Copy link
Owner

Thank you @sachinraja, I could never do this without you!

@sachinraja
Copy link
Contributor Author

Looks like dependabot is failing because it doesn't support yarn >=2 (see dependabot/dependabot-core#1297). I recommend switching to renovate, which has already added support and has a lot more features.

@piglovesyou
Copy link
Owner

That's a helpful tip. Renovate seems nice. I've been thinking Dependabot hasn't worked as expected after being GitHub-native. I'll check it when I get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants