Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode! #1269

Merged
merged 7 commits into from
May 18, 2023
Merged

Add dark mode! #1269

merged 7 commits into from
May 18, 2023

Conversation

make-42
Copy link
Contributor

@make-42 make-42 commented May 8, 2023

No description provided.

This was referenced May 8, 2023
Copy link
Member

@vktr vktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! There are a few things I'd like to change, the biggest is the static Theming class which I think is mostly unnecessary and we can probably get by with a simple helper function on the configuration class.

Also indentation, it should be 4 spaces in all source files.

res/dbmigrations/20220508103321_insert_theme_id.sql Outdated Show resolved Hide resolved
src/picotorrent/application.cpp Outdated Show resolved Hide resolved
src/picotorrent/application.cpp Outdated Show resolved Hide resolved
src/picotorrent/resources.rc Outdated Show resolved Hide resolved
src/picotorrent/ui/dialogs/preferencesgeneralpage.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vktr vktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job on the refactoring - it's mostly formatting and naming fixes that needs to be addressed other than passing a boolean around rather than a full configuration instance. I've left a few suggestions! 😄

src/picotorrent/application.cpp Outdated Show resolved Hide resolved
src/picotorrent/core/configuration.cpp Show resolved Hide resolved
src/picotorrent/core/configuration.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/console.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/console.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.hpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.hpp Outdated Show resolved Hide resolved
@vktr vktr merged commit 79644e8 into picotorrent:master May 18, 2023
@symonxdd
Copy link

symonxdd commented Jul 7, 2024

Any progress on this? I'm also confused... does this PR implement dark mode or?

@make-42
Copy link
Contributor Author

make-42 commented Jul 7, 2024

It does. There has not been a stable release since this PR because @vktr hasn't had the time to test any changes recently due to not having a Windows machine on hand so it's not available if you use the latest release. You should be able to build it yourself if you want or poke @vktr so that he creates a stable release. 😄

@symonxdd
Copy link

symonxdd commented Jul 8, 2024

I appreciate your reply, though can you help me build this? I've never bundled C++ apps before. I'm your typical CS student which knows anything but C and C++ 💀

@make-42
Copy link
Contributor Author

make-42 commented Jul 8, 2024

I can give general informations and suggest steps if things break yeah. I'd rather we have this conversation on the PicoTorrent discord though if you don't mind. There are general instructions in the README.md file. They should work but yeah there might be breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants