-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode! #1269
Add dark mode! #1269
Conversation
…on and set it to default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! There are a few things I'd like to change, the biggest is the static Theming class which I think is mostly unnecessary and we can probably get by with a simple helper function on the configuration class.
Also indentation, it should be 4 spaces in all source files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job on the refactoring - it's mostly formatting and naming fixes that needs to be addressed other than passing a boolean around rather than a full configuration instance. I've left a few suggestions! 😄
Any progress on this? I'm also confused... does this PR implement dark mode or? |
It does. There has not been a stable release since this PR because @vktr hasn't had the time to test any changes recently due to not having a Windows machine on hand so it's not available if you use the latest release. You should be able to build it yourself if you want or poke @vktr so that he creates a stable release. 😄 |
I appreciate your reply, though can you help me build this? I've never bundled C++ apps before. I'm your typical CS student which knows anything but C and C++ 💀 |
I can give general informations and suggest steps if things break yeah. I'd rather we have this conversation on the PicoTorrent discord though if you don't mind. There are general instructions in the README.md file. They should work but yeah there might be breakage. |
No description provided.