-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTL v2.11 #129
Merged
Merged
FTL v2.11 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stored only timestamps for which we actually have found data. This may lead to uncertainties in plotting engines. Signed-off-by: DL6ER <dl6er@dl6er.de>
…parsing Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Ensure that data in overTime data struct in contiguous.
…nts that have zero queries within the most recent 24 hours
…active within the most recent 24 hours (match the behavior of top-clients). Add "clients_ever_seen" to preserve the information of how many unique clients FTL has seen in its runtime (whether or not they have been active recently)
Some tweaks for stats and top-clients
Signed-off-by: DL6ER <dl6er@dl6er.de>
…ew host name Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Re-resolve client host names in regular intervals
Signed-off-by: DL6ER <dl6er@dl6er.de>
…orwarded" lines, i.e. not when analyzing the "query" lines Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Bugfix: Forward destinations counting
…e numbers Signed-off-by: DL6ER <dl6er@dl6er.de>
…d" because these two routines do exactly the same thing. Remove the obsolete function. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
… in memory Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…sake of readability.
…for the sake of readability." This reverts commit 93b57db.
Signed-off-by: DL6ER <dl6er@dl6er.de>
Bugfix: Compute properly normalized percentages
DL6ER
requested review from
PromoFaux,
dschaper,
WaLLy3K,
jacobsalmela and
AzureMarker
September 21, 2017 18:29
PromoFaux
previously approved these changes
Sep 21, 2017
Signed-off-by: DL6ER <dl6er@dl6er.de>
Ensure percentages in forward destinations do always sum up to one
WaLLy3K
reviewed
Sep 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't eyeball the code since I don't understand the language, but all testing so far is looking good 👍
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Always send EOM at end of transmission
Still reviewing. |
Approved |
jacobsalmela
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release