Improve error messages and check for more return codes in various database subroutines #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abase subroutines Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
commented
Jul 18, 2017
| @@ -298,12 +322,12 @@ void save_to_DB(void) | |||
| } | |||
|
|
|||
| // Step and check if successful | |||
| int rc = sqlite3_step(stmt); | |||
There was a problem hiding this comment.
int rc is now defined in line 272
|
|
||
| // Count number of rows using the index timestamp is faster than select(*) | ||
| sqlite3_prepare_v2(db, "SELECT COUNT(timestamp) FROM queries", -1, &stmt, NULL); |
There was a problem hiding this comment.
Added a check for this return value
|
|
||
| // Count number of rows using the index timestamp is faster than select(*) | ||
| sqlite3_prepare_v2(db, "SELECT COUNT(timestamp) FROM queries", -1, &stmt, NULL); | ||
| int rc = sqlite3_step(stmt); | ||
| if (rc == SQLITE_ROW) |
There was a problem hiding this comment.
Disentangled this slightly
| dbclose(); | ||
| return -1; | ||
| } | ||
| free(querystring); | ||
|
|
||
| // Evaluate SQL statement | ||
| sqlite3_step(dbstmt); |
There was a problem hiding this comment.
Forgot to check for this return value here, Thanks @Mcat12
Merged
DL6ER
commented
Jul 18, 2017
| @@ -70,7 +70,6 @@ bool dbquery(const char *format, ...) | |||
| if(query == NULL) | |||
| { | |||
| logg("Memory allocation failed in dbquery()"); | |||
| va_end(args); | |||
There was a problem hiding this comment.
This is already called before in line 68. No need to do it again.
AzureMarker
approved these changes
Jul 22, 2017
DL6ER
pushed a commit
that referenced
this pull request
Oct 14, 2019
Add /stats/database/top_clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
Improve error messages and check for more return codes in various database subroutines
This template was created based on the work of
udemy-dl.