Skip to content

Potential NULL parameter to strlen #91

Closed
@stumpylog

Description

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

  • I have read and understood the contributors guide.
  • The issue I am reporting can be replicated
  • The issue I am reporting isn't a duplicate

How familiar are you with the codebase?:

2


[BUG] Expected Behaviour:
If a pointer is NULL, it should not be passed as a parameter or used

[BUG] Actual Behaviour:
In parser.c, starting at line 711, the variable part is allocated. The return is checked for NULL, but only logged. part is then provided as an argument to strlen, which would result in undefined behaviour. But probably a segfault in most cases.

I'd consider it very unlikely to be run into/fail, but since the check for NULL is already there, might as well not use the NULL? Perhaps the call to logg will halt or set an error, but I didn't notice anything

[BUG] Steps to reproduce:
image

Device specifics

Hardware Type: rPi, VPS, etc
OS: N/A

This template was created based on the work of udemy-dl.

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions