"Unable to resolve template type" has to check against explicit Never…

…Type only
phpstan · Jan 24, 2021 · ba4bc4f · ba4bc4f
1 parent e5bac6e
commit ba4bc4f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/Rules/FunctionCallParametersCheck.php b/src/Rules/FunctionCallParametersCheck.php
@@ -311,7 +311,13 @@ static function (Type $type): bool {
 			});
 
 			foreach ($parametersAcceptor->getResolvedTemplateTypeMap()->getTypes() as $name => $type) {
-				if (!($type instanceof ErrorType) && !($type instanceof NeverType)) {
+				if (
+					!($type instanceof ErrorType)
+					&& (
+						!$type instanceof NeverType
+						|| $type->isExplicit()
+					)
+				) {
 					continue;
 				}
 

diff --git a/tests/PHPStan/Rules/Functions/data/call-generic-function.php b/tests/PHPStan/Rules/Functions/data/call-generic-function.php
@@ -25,3 +25,20 @@ function g($a) {}
 function testg(): void {
 	g(new \DateTimeImmutable());
 }
+
+/**
+ * @template TReturnType
+ * @param (callable(): TReturnType) $callback
+ * @return TReturnType
+ */
+function scope(callable $callback) {
+	return $callback();
+}
+
+function (): void {
+	scope(
+		function (): void {
+			throw new \Exception();
+		}
+	);
+};