Turns out static method can be called on a trait

phpstan · Nov 20, 2020 · 86c11d3 · 86c11d3
1 parent f000222
commit 86c11d3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/src/Rules/Methods/CallStaticMethodsRule.php b/src/Rules/Methods/CallStaticMethodsRule.php
@@ -136,15 +136,6 @@ public function processNode(Node $node, Scope $scope): array
 				}
 
 				$classReflection = $this->reflectionProvider->getClass($className);
-				if ($classReflection->isTrait()) {
-					return [
-						RuleErrorBuilder::message(sprintf(
-							'Call to static method %s() on trait %s.',
-							$methodName,
-							$className
-						))->build(),
-					];
-				}
 			}
 
 			$className = $classReflection->getName();

diff --git a/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php
@@ -219,10 +219,6 @@ public function testCallStaticMethods(): void
 				'Call to an undefined static method CallStaticMethods\Foo::nonexistentMethod().',
 				303,
 			],
-			[
-				'Call to static method doFoo() on trait CallStaticMethods\TraitWithStaticMethod.',
-				323,
-			],
 			[
 				'Call to static method doFoo() on an unknown class CallStaticMethods\TraitWithStaticMethod.',
 				328,
-Original file line number
+Diff line change
@@ Expand Up / @@ -219,10 +219,6 @@ public function testCallStaticMethods(): void @@
     				'Call to an undefined static method CallStaticMethods\Foo::nonexistentMethod().',
 ,
     			],
-    			[
-    				'Call to static method doFoo() on trait CallStaticMethods\TraitWithStaticMethod.',
-,
-    			],
     			[
     				'Call to static method doFoo() on an unknown class CallStaticMethods\TraitWithStaticMethod.',
 ,
@@ Expand Down @@