Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autorehash in RedisArray constructor options Doesn't Work #294

Closed
mocheng opened this issue Feb 2, 2013 · 6 comments
Closed

autorehash in RedisArray constructor options Doesn't Work #294

mocheng opened this issue Feb 2, 2013 · 6 comments
Labels
need feedback

Comments

@mocheng
Copy link

mocheng commented Feb 2, 2013

I tried main branch and tag 2.2.2. It turns out that, as code below, autorehash doesn't trigger migration of keys among nodes.

$options = array(0;
$options['previous'] = $previous_server_list;
$options['autorehash'] = TRUE;
$ra = new RedisArray($server_list, $options);

Is there something missing in https://github.com/nicolasff/phpredis/blob/master/arrays.markdown#readme ?
@michael-grunder
Copy link
Member

Hey there,

I will try to replicate this problem for you tonight or tomorrow.

Cheers,
Mike

@nicolasff
Copy link
Member

Morgan,

The "autorehash" feature is tested and the tests are currently passing on master.
Reading a key from the $server_list can fail if the it is different from $previous_server_list. When this happens, the RedisArray object will look it up in the previous ring. When autorehash is enabled, this read will trigger a write to the new ring, so that subsequent reads are resolved in a single step.

Have a look at tests/array-tests.php, in the Redis_Auto_Rehashing_Test class. It writes 1,000 keys to a ring, then adds a node to the ring, reads back all the keys (triggering a rehash and migrating them one by one), before checking that they have all been migrated successfully.

@mocheng
Copy link
Author

mocheng commented Feb 21, 2013

Thanks for your reply. I'll try it out:)

@chaosue
Copy link

chaosue commented Jul 29, 2013

not work！

the Redis_Auto_Rehashing_Test passed just because there's a Redis_Rehashing_Tes before it.
If you comment "run_tests('Redis_Rehashing_Test') " then run_tests('Redis_Auto_Rehashing_Test') fails.

@koda611
Copy link

koda611 commented Mar 7, 2014

I just tried this today, and it doesn't auto rehash. Can anyone verify that this is working?

michael-grunder added a commit that referenced this issue Mar 10, 2014
@michael-grunder
Fix autorehashing in RedisArray
f72a317 
This commit fixes auto rehashing in RedisArray as well as fixes
a couple of memory leaks found along the way

Addresses #442 and #294
@michael-grunder
Copy link
Member

Hey there, can you please test the branch hotfix/ra_autorehash. I believe this commit sorts it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicolasff @mocheng @michael-grunder @chaosue @koda611