Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #1049

Merged
merged 4 commits into from
Dec 10, 2023
Merged

Allow Symfony 7 #1049

merged 4 commits into from
Dec 10, 2023

Conversation

kylekatarnls
Copy link
Member

@kylekatarnls kylekatarnls commented Dec 7, 2023

Type: compatibility
Breaking change: no
Follows up pdepend/pdepend#699

  • Update to PDepend 2.16.1 (supporting Symfony 7)
  • Move test dependencies in the test folder (so it can have different Symfony packages version without conflict)
  • Test each Symfony version in GitHub Actions
  • Make composer test automatically installing test dependencies

@kylekatarnls kylekatarnls force-pushed the fix/symfony-compatibility branch from 9bbe6b2 to 301217c Compare December 7, 2023 18:42
@ravage84
Copy link
Member

ravage84 commented Dec 7, 2023

My remarks and potential issues raised in pdepend/pdepend#699 can be applied here, too.

@kylekatarnls kylekatarnls force-pushed the fix/symfony-compatibility branch from b819f7f to b3d9838 Compare December 8, 2023 07:44
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8662ff2) 92.53% compared to head (78f7569) 92.53%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1049   +/-   ##
=========================================
  Coverage     92.53%   92.53%           
  Complexity     1239     1239           
=========================================
  Files           111      111           
  Lines          3404     3404           
=========================================
  Hits           3150     3150           
  Misses          254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylekatarnls kylekatarnls changed the title Test each Symfony version Allow Symfony 7 Dec 8, 2023
@kylekatarnls kylekatarnls force-pushed the fix/symfony-compatibility branch from 5f1a36e to e8a10c6 Compare December 10, 2023 14:43
@kylekatarnls kylekatarnls force-pushed the fix/symfony-compatibility branch from e8a10c6 to 78f7569 Compare December 10, 2023 18:44
@kylekatarnls kylekatarnls marked this pull request as ready for review December 10, 2023 18:44
@kylekatarnls kylekatarnls added this to the 2.15.0 milestone Dec 10, 2023
@kylekatarnls kylekatarnls merged commit 4a75765 into master Dec 10, 2023
73 checks passed
@kylekatarnls kylekatarnls deleted the fix/symfony-compatibility branch December 10, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants