Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal error on startup with Symfony 7.x due to changes in command naming #420

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fix fatal error on startup with Symfony 7.x due to changes in command naming #420

merged 3 commits into from
Jan 16, 2024

Conversation

ben-challis
Copy link
Contributor

@ben-challis ben-challis commented Jan 15, 2024 •
edited
Loading

Fixes #419

Aligns with Check command which does:

    public function __construct()
    {
        parent::__construct('check');
    }

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc7b3a0) 94.33% compared to head (290f831) 94.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #420      +/-   ##
============================================
+ Coverage     94.33%   94.35%   +0.01%     
- Complexity      571      573       +2     
============================================
  Files            67       67              
  Lines          1501     1505       +4     
============================================
+ Hits           1416     1420       +4     
  Misses           85       85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ben-challis ben-challis changed the title Symfony 7.x support in Init Command Fix fatal error on startup with Symfony 7.x due to changes in command naming Jan 15, 2024
@ben-challis ben-challis marked this pull request as ready for review January 15, 2024 16:26
@vibby
Copy link

vibby commented Jan 16, 2024

Thank you for PR, I was just starting to propose it too :) Can you please run php-cs-fixer to fix CI @ben-challis ?

@ben-challis
Copy link
Contributor Author

The code style issues look to be unrelated to the changes in this PR and pre-existing but yep sure, I'll do it in a separate PR

src/Analyzer/NameResolver.php (phpdoc_add_missing_param_annotation, fully_qualified_strict_types, no_superfluous_phpdoc_tags)

@ben-challis
Copy link
Contributor Author

@vibby #421

@vibby
Copy link

vibby commented Jan 16, 2024

Can you merge this too please @fain182 ?

@fain182 fain182 merged commit 96375f3 into phparkitect:main Jan 16, 2024
17 checks passed
@ben-challis ben-challis deleted the patch-1 branch January 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error on start with symfony/console 7.x due to changes in command names
4 participants
@ben-challis @codecov-commenter @vibby @fain182