Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with an evaluable return code #34

Merged
merged 2 commits into from
May 3, 2017

Conversation

raphaelstolt
Copy link
Contributor

Validate command can now be evaluated.

@pmjones
Copy link

pmjones commented May 2, 2017

You're right; there should be an evaluable exit. But the place to put it is not in the execute() method; instead, it should be in the bin/pds-skeleton script. If you can, modify this PR (or submit a new PR) so that bin/pds-skeleton takes the return from the execute() method, and then uses that for an exit code. Make sense?

@raphaelstolt
Copy link
Contributor Author

Done via 7e1a096.

@pmjones
Copy link

pmjones commented May 2, 2017

@raphaelstolt right on!

@afilina -- please review, if you have the time and inclination.

@afilina
Copy link
Contributor

afilina commented May 3, 2017

Read code: ✓
Executed tests: ✓
Executed code: ✓

@pmjones pmjones merged commit c2037b7 into php-pds:1.x May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants