Generate/Validate skeletons in arbitrary path #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepehr
changed the title
|
Nice! @afilina any comments? |
|
The tests pass and everything works as expected. I'd merge it. P.S. I hope that people won't install it globally, since I believe that the original goal of the package was to make sure authors install it per project, to signal adherence to the standard. |
Same here. Even so, I can see a case for validating packages that have not yet required it, and then informing the package owners that they're compliant. |
afilina
added a commit
to afilina/skeleton
that referenced
this pull request
Jan 21, 2017
Add optional path argument for validator and generator.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's only possible to use the pds-skeleton when it's required locally. When it's required globally, it will only generate/validate packages in the
~/.composerpath.This pull-request enables the pds-skeleton to generate/validate package skeletons in any existing arbitrary path. If no path is provided, it will fallback to its default behavior. Here's a usage example:
Along the way, it fixes a bug in validator's
getFiles()where it was unable to correctly detect if an entry is a directory or not. I didn't open a separate pull-request for this as it has merge conflicts with this one.