Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator #25

Merged
merged 3 commits into from
Jan 3, 2017
Merged

Generator #25

merged 3 commits into from
Jan 3, 2017

Conversation

afilina
Copy link
Contributor

@afilina afilina commented Jan 2, 2017

Refactored validator and added package generator cli tool. #23

@afilina afilina mentioned this pull request Jan 2, 2017
Closed
@pmjones
Copy link

pmjones commented Jan 2, 2017

A couple of things stand out to me:

  1. Let's use Pds\ instead of PDS\.

  2. Under PSR-4, the directories can be collapsed for the namespace prefix, so the source code can be directly in the src/ directory, and don't need to be in src/Pds/Skeleton/. Can you move those files, and update the composer.json in line with that ("psr-4": { "PDS\\Skeleton\\": "src/" }) ?

@afilina
Copy link
Contributor Author

afilina commented Jan 3, 2017

@pmjones I made the changes.

@pmjones
Copy link

pmjones commented Jan 3, 2017

I see some minor issues but no blockers. Thanks!

@pmjones pmjones merged commit 20adda9 into php-pds:1.x Jan 3, 2017
@afilina
Copy link
Contributor Author

afilina commented Jan 3, 2017

Let me know how I can improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afilina @pmjones