Compliance validator #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 1, 2017
| Quickly validate your project's compliance by following these steps: | ||
|
|
||
| - Install package in your project: `composer require pds/skeleton @dev` | ||
| - Run the validator: `./vendor/pds/skeleton/bin/validate` |
There was a problem hiding this comment.
should the validator be exposed by composer in vendor/bin ? This would be more common (it should be renamed to a less generic name to avoid clashes of course)
|
See my issue on the research project about inconsistent behavior of the compliance checker: php-pds/skeleton_research#1 I think this should be solved before shipping a validator in the main package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filesystem validator that runs from the command-line. #20