-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor/
Directory Considerations
#19
Comments
This is a very good point. Now that I think about it, I have tried very hard to support each point in the draft with research. However, the bits about "not committing to version control" are a habitual bias toward Composer, and not strictly supported by the findings. Perhaps the thing to do is say "reserved for package managers ... not otherwise defined" and leave the rest out? |
I think that will suffice. |
Indeed, on further consideration, the research shows a lack of |
@ramsey You might want to submit a PR with the changes you'd like to see, because then you get automatic credit via GitHub. (You can go so far as to remove the |
Will do. Thanks! |
@ramsey If you don't think you'll get around to it in the next couple of days, I can take care of it. Let me know! |
It'll be a few days before I can get to it. I haven't had Internet access since December 16. Long story. :-) |
Noted, and good luck with the internet situation. |
This is just me thinking - why not add a vendor directory and a .gitignore file (excluding it) so that it is clear that the directory exists but is ignored |
While libraries shouldn't commit the vendor directory to version control, there are instances where it might be beneficial for projects to commit the vendor directory.
Open for discussion, consider revising the
vendor/
section to read:The text was updated successfully, but these errors were encountered: