more work for PHP 8 #383
Merged
more work for PHP 8 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build php-amqp master.12 completed (commit 8c91d703d4 by @remicollet) |
|
Using PHP_VERSION : 8.0.0beta2 |
remicollet
commented
Aug 31, 2020
| @@ -331,7 +336,7 @@ static PHP_METHOD(amqp_channel_class, __construct) | |||
| amqp_connection_object *connection; | |||
|
|
|||
| /* Parse out the method parameters */ | |||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "o", &connection_object) == FAILURE) { | |||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "O", &connection_object, amqp_connection_class_entry) == FAILURE) { | |||
There was a problem hiding this comment.
Ensure parameter type is checked (warning with php 5 and 7, TypeError exception with php 8)
remicollet
commented
Aug 31, 2020
| @@ -65,20 +65,20 @@ static PHP_METHOD(amqp_exchange_class, __construct) | |||
| zval *channelObj; | |||
| amqp_channel_resource *channel_resource; | |||
|
|
|||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "o", &channelObj) == FAILURE) { | |||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "O", &channelObj, amqp_channel_class_entry) == FAILURE) { | |||
There was a problem hiding this comment.
Ensure parameter type is checked...
remicollet
commented
Aug 31, 2020
| @@ -68,20 +68,20 @@ static PHP_METHOD(amqp_queue_class, __construct) | |||
| zval *channelObj; | |||
| amqp_channel_resource *channel_resource; | |||
|
|
|||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "o", &channelObj) == FAILURE) { | |||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "O", &channelObj, amqp_channel_class_entry) == FAILURE) { | |||
There was a problem hiding this comment.
Ensure parameter type is checked...
|
✅ Build php-amqp master.13 completed (commit 945bc2f305 by @remicollet) |
|
For constructor, for consistency, perhaps better to switch to zend_parse_parameters_throw |
|
Looks good, thank you! |
rgomezcasas
added a commit
to CodelyTV/php-ddd-example
that referenced
this pull request
Nov 10, 2020
rgomezcasas
added a commit
to CodelyTV/php-ddd-example
that referenced
this pull request
Nov 10, 2020
rgomezcasas
added a commit
to CodelyTV/php-ddd-example
that referenced
this pull request
Nov 10, 2020
|
win32/php_stdint.h does not exist anymore in PHP 8. A generic solution could use something like this It checks if a MSVC compiler is used and if the VC compiler is VC15 or less. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly about property function arg change from zval to zend_object.