Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support AMQP for array and timestamp types for dead lettering #272

Merged
merged 16 commits into from
Mar 6, 2017

Conversation

lstrojny
Copy link
Collaborator

@lstrojny lstrojny commented Mar 3, 2017

PR for #271

@lstrojny lstrojny force-pushed the dev/extended-type-support branch 3 times, most recently from 1a2740d to 6f86475 Compare March 3, 2017 17:57
@lstrojny
Copy link
Collaborator Author

lstrojny commented Mar 3, 2017

@pinepain The array changes are now ready for review. I extracted amqp_type file to handle all the type conversion logic.

@lstrojny lstrojny force-pushed the dev/extended-type-support branch from 6f86475 to f120cc7 Compare March 3, 2017 18:56
@lstrojny lstrojny force-pushed the dev/extended-type-support branch from 6ba4659 to d66218e Compare March 4, 2017 22:56
@lstrojny lstrojny force-pushed the dev/extended-type-support branch from d66218e to 557ab05 Compare March 4, 2017 23:01
@lstrojny lstrojny changed the title Convert numeric PHP array to AMQP array instead of table Support AMQP array and timestamp types properly for dead lettering Mar 5, 2017
@lstrojny lstrojny changed the title Support AMQP array and timestamp types properly for dead lettering Proper support AMQP array and timestamp types for dead lettering Mar 6, 2017
@lstrojny lstrojny changed the title Proper support AMQP array and timestamp types for dead lettering Proper support AMQP for array and timestamp types for dead lettering Mar 6, 2017
@lstrojny
Copy link
Collaborator Author

lstrojny commented Mar 6, 2017

@remicollet as I don’t have a windows build environment, would you mind building this branch on windows and running the tests?

@remicollet
Copy link
Contributor

@lstrojny sorry, I don't even know what Windows is ;)

@pinepain
Copy link
Contributor

pinepain commented Mar 6, 2017

@lstrojny maybe appveyour could help? e.g. here is config I use in php-ref - https://github.com/pinepain/php-ref/blob/master/appveyor.yml, though, not sure how to install librabbitmq-c.

Alternatively, we could release on pecl and see how it will go 😄.

@lstrojny lstrojny merged commit 0b41dad into master Mar 6, 2017
@lstrojny lstrojny deleted the dev/extended-type-support branch March 6, 2017 16:58
@lstrojny lstrojny restored the dev/extended-type-support branch April 3, 2020 17:18
@lstrojny lstrojny deleted the dev/extended-type-support branch April 3, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants