Compile failure on php 7.4 #355

monteiro · 2019-12-02T20:42:30Z

After installing php 7.4 and run:

pecl install amqp

I got some compilation errors.

running: make
/bin/sh /private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/libtool --mode=compile cc  -I. -I/private/tmp/pear/temp/amqp -DPHP_ATOM_INC -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/include -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/main -I/private/tmp/pear/temp/amqp -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib -I/usr/local/Cellar/rabbitmq-c/0.9.0_1/include  -DHAVE_CONFIG_H  -g -O2   -c /private/tmp/pear/temp/amqp/amqp.c -o amqp.lo
mkdir .libs
 cc -I. -I/private/tmp/pear/temp/amqp -DPHP_ATOM_INC -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/include -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/main -I/private/tmp/pear/temp/amqp -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib -I/usr/local/Cellar/rabbitmq-c/0.9.0_1/include -DHAVE_CONFIG_H -g -O2 -c /private/tmp/pear/temp/amqp/amqp.c  -fno-common -DPIC -o .libs/amqp.o
/bin/sh /private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/libtool --mode=compile cc  -I. -I/private/tmp/pear/temp/amqp -DPHP_ATOM_INC -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/include -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/main -I/private/tmp/pear/temp/amqp -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib -I/usr/local/Cellar/rabbitmq-c/0.9.0_1/include  -DHAVE_CONFIG_H  -g -O2   -c /private/tmp/pear/temp/amqp/amqp_type.c -o amqp_type.lo
 cc -I. -I/private/tmp/pear/temp/amqp -DPHP_ATOM_INC -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/include -I/private/tmp/pear/temp/pear-build-hugoqKJyG7/amqp-1.9.4/main -I/private/tmp/pear/temp/amqp -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib -I/usr/local/Cellar/rabbitmq-c/0.9.0_1/include -DHAVE_CONFIG_H -g -O2 -c /private/tmp/pear/temp/amqp/amqp_type.c  -fno-common -DPIC -o .libs/amqp_type.o
/private/tmp/pear/temp/amqp/amqp_type.c:87:7: error: expected ';' after expression
        ulong index;
             ^
             ;
/private/tmp/pear/temp/amqp/amqp_type.c:87:2: error: use of undeclared identifier 'ulong'
        ulong index;
        ^
/private/tmp/pear/temp/amqp/amqp_type.c:92:2: error: non-object type 'char *(const char *, int)' is not assignable
        PHP5to7_ZEND_HASH_FOREACH_KEY_VAL(ht, index, real_key, key, key_len, data, value, pos) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/private/tmp/pear/temp/amqp/php7_support.h:78:3: note: expanded from macro 'PHP5to7_ZEND_HASH_FOREACH_KEY_VAL'
  ZEND_HASH_FOREACH_KEY_VAL((ht), (num_key), (real_key), (val))
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/Cellar/php/7.4.0/include/php/Zend/zend_hash.h:1005:5: note: expanded from macro 'ZEND_HASH_FOREACH_KEY_VAL'
        _h = _p->h; \
        ~~ ^
/private/tmp/pear/temp/amqp/amqp_type.c:87:8: warning: expression result unused [-Wunused-value]
        ulong index;
              ^~~~~
/private/tmp/pear/temp/amqp/amqp_type.c:122:7: error: expected ';' after expression
        ulong index;
             ^
             ;
/private/tmp/pear/temp/amqp/amqp_type.c:122:2: error: use of undeclared identifier 'ulong'
        ulong index;
        ^
/private/tmp/pear/temp/amqp/amqp_type.c:130:2: error: non-object type 'char *(const char *, int)' is not assignable
        PHP5to7_ZEND_HASH_FOREACH_KEY_VAL(ht, index, real_key, key, key_len, data, value, pos) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/private/tmp/pear/temp/amqp/php7_support.h:78:3: note: expanded from macro 'PHP5to7_ZEND_HASH_FOREACH_KEY_VAL'
  ZEND_HASH_FOREACH_KEY_VAL((ht), (num_key), (real_key), (val))
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/Cellar/php/7.4.0/include/php/Zend/zend_hash.h:1005:5: note: expanded from macro 'ZEND_HASH_FOREACH_KEY_VAL'
        _h = _p->h; \
        ~~ ^
/private/tmp/pear/temp/amqp/amqp_type.c:143:35: warning: format specifies type 'unsigned long' but the argument has type 'char *(*)(const char *, int)' [-Wformat]
                                key_len = sprintf(str, "%lu", index);
                                                        ~~~   ^~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/secure/_stdio.h:47:56: note: expanded from macro 'sprintf'
  __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__)
                                                       ^~~~~~~~~~~
/private/tmp/pear/temp/amqp/amqp_type.c:147:91: warning: format specifies type 'unsigned long' but the argument has type 'char *(*)(const char *, int)' [-Wformat]
                                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Ignoring non-string header field '%lu'", index);
                                                                                                               ~~~    ^~~~~
/private/tmp/pear/temp/amqp/amqp_type.c:122:8: warning: expression result unused [-Wunused-value]
        ulong index;
              ^~~~~
/private/tmp/pear/temp/amqp/amqp_type.c:185:7: error: expected ';' after expression
        ulong index;
             ^
             ;
/private/tmp/pear/temp/amqp/amqp_type.c:185:2: error: use of undeclared identifier 'ulong'
        ulong index;
        ^
/private/tmp/pear/temp/amqp/amqp_type.c:195:2: error: non-object type 'char *(const char *, int)' is not assignable
        PHP5to7_ZEND_HASH_FOREACH_KEY_VAL(ht, index, real_key, key, key_len, data, value, pos) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/private/tmp/pear/temp/amqp/php7_support.h:78:3: note: expanded from macro 'PHP5to7_ZEND_HASH_FOREACH_KEY_VAL'
  ZEND_HASH_FOREACH_KEY_VAL((ht), (num_key), (real_key), (val))
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/Cellar/php/7.4.0/include/php/Zend/zend_hash.h:1005:5: note: expanded from macro 'ZEND_HASH_FOREACH_KEY_VAL'
        _h = _p->h; \
        ~~ ^
/private/tmp/pear/temp/amqp/amqp_type.c:185:8: warning: expression result unused [-Wunused-value]
        ulong index;
              ^~~~~
5 warnings and 9 errors generated.
make: *** [amqp_type.lo] Error 1
ERROR: `make' failed

The text was updated successfully, but these errors were encountered:

signor-pedro · 2019-12-04T09:20:37Z

I have the same problem

marartner · 2019-12-04T14:55:38Z

same here!

panosru · 2019-12-09T11:53:56Z

diff --git a/a/amqp_type.c b/b/amqp_type.c
index 60518f9..2080ccc 100644
--- a/a/amqp_type.c
+++ b/b/amqp_type.c
@@ -84,7 +84,7 @@ void php_amqp_type_internal_convert_zval_array(zval *php_array, amqp_field_value
 	char *key;
 	uint key_len;
 
-	ulong index;
+	zend_ulong index;
 	ht = Z_ARRVAL_P(php_array);
 
 	zend_bool is_amqp_array = 1;
@@ -119,7 +119,7 @@ void php_amqp_type_internal_convert_zval_to_amqp_table(zval *php_array, amqp_tab
 	char *key;
 	uint key_len;
 
-	ulong index;
+	zend_ulong index;
 
 
 	ht = Z_ARRVAL_P(php_array);
@@ -182,7 +182,7 @@ void php_amqp_type_internal_convert_zval_to_amqp_array(zval *zvalArguments, amqp
 	char *key;
 	uint key_len;
 
-	ulong index;
+	zend_ulong index;
 
 	char type[16];

If you are on macOS then you need to run brew install rabbitmq-c, after than run brew info rabbitmq-c, it will output something like this:

rabbitmq-c: stable 0.10.0 (bottled), HEAD
RabbitMQ C client
https://github.com/alanxz/rabbitmq-c
/usr/local/Cellar/rabbitmq-c/0.10.0 (20 files, 489.4KB) *
  Poured from bottle on 2019-12-05 at 00:42:00
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/rabbitmq-c.rb
==> Dependencies
Build: cmake, pkg-config
Required: openssl@1.1, popt
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 595 (30 days), 1,544 (90 days), 4,720 (365 days)
install-on-request: 473 (30 days), 1,238 (90 days), 3,853 (365 days)
build-error: 0 (30 days)

then you can build amqp like this:

# git clone https://github.com/pdezwart/php-amqp.git
# phpize
# ./configure --with-librabbitmq-dir=/usr/local/Cellar/rabbitmq-c/0.10.0
# make && make install

Then you just add extension=amqp to your php.ini, restart your php service and you are good to go:

Keep in mind, this will download the latest commit in master. To wit: I have v1.9.5-dev; if you need the latest stable release, before phpize you have to run git checkout tags/v1.9.4 ./ where v1.9.4 will be equivalent to the current latest stable release at the time you read this.

ahilles107 · 2019-12-10T13:07:31Z

I forked master and applied those changes to my fork. You can use it with phpbrew like that: phpbrew ext install github:ahilles107/php-amqp

cmb69 · 2019-12-11T17:59:50Z

For reference: php/php-src@bebcdcc

Nyholm · 2020-01-02T12:36:24Z

Thank you @panosru for the fix.

I can confirm that it is working.

lstrojny · 2020-01-02T14:41:06Z

@ahilles107 could you open a PR?

As of PHP 7.4.0, portable definitions of `ulong` and `uint` are no longer available. Therefore we replace `uint` with `unsigned`, and `ulong` with `zend_ulong`.

ahilles107 · 2020-01-02T17:56:36Z

I can but i see that @cmb69 have even better fix in his fork.

cmb69 · 2020-01-02T18:00:38Z

To clarify: the uint → unsigned replacement is necessary for Windows (at least).

renedelima · 2020-01-15T20:27:00Z

If you are on macOS then you need to run brew install rabbitmq-c, after than run brew info rabbitmq-c, it will output something like this:

rabbitmq-c: stable 0.10.0 (bottled), HEAD
RabbitMQ C client
https://github.com/alanxz/rabbitmq-c
/usr/local/Cellar/rabbitmq-c/0.10.0 (20 files, 489.4KB) *
Poured from bottle on 2019-12-05 at 00:42:00
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/rabbitmq-c.rb
=> Dependencies
Build: cmake, pkg-config
Required: openssl@1.1, popt
=> Options
--HEAD
Install HEAD version
=> Analytics
install: 595 (30 days), 1,544 (90 days), 4,720 (365 days)
install-on-request: 473 (30 days), 1,238 (90 days), 3,853 (365 days)
build-error: 0 (30 days)

then you can build amqp like this:

git clone https://github.com/pdezwart/php-amqp.git
phpize
./configure --with-librabbitmq-dir=/usr/local/Cellar/rabbitmq-c/0.10.0
make && make install

Perfect. It worked on macOS 10.15.2. Thank you @panosru!

anoopd · 2021-01-09T02:24:42Z

@renedelima Shouldn't we cd to php-amqp before phpize ?

panosru mentioned this issue Dec 8, 2019

[BUG]: Compile error for v4.0.0-RC.R3 on macOS 10.15.1 and PHP 7.4.0 phalcon/cphalcon#14577

Closed

ludoge mentioned this issue Dec 10, 2019

Skip failing tests for 7.4 #358

Closed

cmb69 added a commit to cmb69/php-amqp that referenced this issue Jan 2, 2020

Fix php-amqp#355: update phpredis for php 7.4

8f4ee96

As of PHP 7.4.0, portable definitions of `ulong` and `uint` are no longer available. Therefore we replace `uint` with `unsigned`, and `ulong` with `zend_ulong`.

cmb69 added a commit to cmb69/php-amqp that referenced this issue Jan 2, 2020

Fix php-amqp#355: Compile failure on php 7.4

4566555

As of PHP 7.4.0, portable definitions of `ulong` and `uint` are no longer available. Therefore we replace `uint` with `unsigned`, and `ulong` with `zend_ulong`.

ahilles107 mentioned this issue Jan 2, 2020

Replace ulong with zend_ulong #360

Merged

lstrojny closed this as completed in ca064a4 Jan 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compile failure on php 7.4 #355

Compile failure on php 7.4 #355

monteiro commented Dec 2, 2019

signor-pedro commented Dec 4, 2019

marartner commented Dec 4, 2019

panosru commented Dec 9, 2019 •

edited

Loading

ahilles107 commented Dec 10, 2019

cmb69 commented Dec 11, 2019

Nyholm commented Jan 2, 2020

lstrojny commented Jan 2, 2020

ahilles107 commented Jan 2, 2020

cmb69 commented Jan 2, 2020

renedelima commented Jan 15, 2020

anoopd commented Jan 9, 2021

Compile failure on php 7.4 #355

Compile failure on php 7.4 #355

Comments

monteiro commented Dec 2, 2019

signor-pedro commented Dec 4, 2019

marartner commented Dec 4, 2019

panosru commented Dec 9, 2019 • edited Loading

ahilles107 commented Dec 10, 2019

cmb69 commented Dec 11, 2019

Nyholm commented Jan 2, 2020

lstrojny commented Jan 2, 2020

ahilles107 commented Jan 2, 2020

cmb69 commented Jan 2, 2020

renedelima commented Jan 15, 2020

anoopd commented Jan 9, 2021

panosru commented Dec 9, 2019 •

edited

Loading