Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda Deployment Optimisation #338

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Conda Deployment Optimisation #338

merged 6 commits into from
Feb 8, 2023

Conversation

denproc
Copy link
Collaborator

@denproc denproc commented Feb 5, 2023

Closes #299

Proposed Changes

  • updated meta.yml for conda recipe to match requirements.txt
  • updated requirements.txt to avoid torchvision==0.9.0 only
  • optimise conda deployment creating only one package, which is architecture and python independent

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #338 (04383c5) into master (d04a848) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          34       34           
  Lines        2491     2491           
=======================================
  Hits         2292     2292           
  Misses        199      199           
Flag Coverage Δ
unittests 92.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@denproc denproc changed the title DRAFT: unify dependency version across pipelines DRAFT: Conda Deployment Optimisation Feb 5, 2023
@denproc denproc marked this pull request as ready for review February 6, 2023 21:30
@denproc denproc requested review from zakajd and snk4tr February 6, 2023 21:30
@denproc denproc changed the title DRAFT: Conda Deployment Optimisation Conda Deployment Optimisation Feb 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@snk4tr snk4tr merged commit 1fa3923 into master Feb 8, 2023
@denproc denproc deleted the bug/conda_recipe branch February 11, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between Torchvision versions in requirements.txt and meta.yaml
2 participants