This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Adds promise scan .done particularly to handle "No cameras" error #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Timeout is needed so that the .done finalizer below has some time | ||
| // to be attached to the promise. | ||
| BarcodeReader.scanPromise = WinJS.Promise.timeout(200, WinJS.Promise.wrap(createPreview())) |
There was a problem hiding this comment.
Not sure, why timeout is required, since composing a promise chain is sync, but perhaps this has something to do with sync createPreview being wrapped into promise. You might want to make createPreview return promise instead of this workaround.
There was a problem hiding this comment.
Turns out that WinJS.Promise.as and WinJS.Promise.wrap is sync so their contents are run before we get to the next statement - .done in our case, therefore the timeout() is required here to mark the promise contents as async.
|
Addressed, thanks for review @vladimir-kotikov ! |
|
LGTM |
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #361