Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make entrypoint executable on unix when sidekick is executed on windows #23

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Make entrypoint executable on unix when sidekick is executed on windows #23

merged 3 commits into from
Mar 11, 2022

Conversation

passsy
Copy link
Contributor

@passsy passsy commented Mar 9, 2022 •
edited
Loading

@passsy passsy force-pushed the entrypoint-executable-on-windows branch 2 times, most recently from 35abcb4 to 57b51cd Compare March 11, 2022 10:10
@passsy passsy force-pushed the entrypoint-executable-on-windows branch from 57b51cd to 8d43aa3 Compare March 11, 2022 10:12
@passsy
Copy link
Contributor Author

passsy commented Mar 11, 2022

Double checked it on windows

jxstxn1
jxstxn1 approved these changes Mar 11, 2022
View reviewed changes
sidekick/lib/src/init/init_command.dart Outdated Show resolved Hide resolved
@passsy
Fix typo sidekick/lib/src/init/init_command.dart
54f0a23 
Co-authored-by: jxstxn__ <justin@phntm.xyz>
@passsy passsy merged commit 2f33688 into main Mar 11, 2022
@passsy passsy deleted the entrypoint-executable-on-windows branch March 11, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxstxn1 jxstxn1 jxstxn1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@passsy @jxstxn1