Enable update check for everyone #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passsy
force-pushed
the
enforce-update-check
branch
from
a7d5571 to
ce14088
Compare
Giuspepe
approved these changes
Jan 11, 2023
| @@ -197,23 +197,29 @@ class SidekickCommandRunner<T> extends CommandRunner<T> { | |||
| Repository.requiredSidekickPackage, | |||
| ['dependencies', 'sidekick_core'], | |||
| ); | |||
| if (sidekickCoreVersion == null) { | |||
| // Couldn't parse sidekick_core version. Most likely because it uses | |||
There was a problem hiding this comment.
We could fallback to VersionChecker.getResolvedVersion because pubspec.lock contains version information for git or path dependencies as well. But that's probably overkill, so you can ignore this comment
There was a problem hiding this comment.
Good idea for the future 👍
Co-authored-by: Giuseppe Cianci <39117631+Giuspepe@users.noreply.github.com>
passsy
force-pushed
the
enforce-update-check
branch
from
3c7d736 to
44e6b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered, that our update check, which was hidden behind a flag works fine in the wild. Time to enable it for everyone
Land after #180