Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHPUnit 7 support. #962

Merged
merged 11 commits into from
Oct 3, 2018
Merged

Added PHPUnit 7 support. #962

merged 11 commits into from
Oct 3, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 29, 2018

Fixed #952

@siad007 siad007 added this to the 3.0.0-alpha2 milestone Sep 29, 2018
This was referenced Sep 29, 2018
Closed
Closed
@siad007 siad007 merged commit ee56953 into phingofficial:master Oct 3, 2018
@siad007 siad007 deleted the phpunit7 branch October 3, 2018 16:56
@MaXal
Copy link

MaXal commented Oct 4, 2018

This commit produces:

Fatal error: Declaration of PHPUnitResultFormatter7::addError(PHPUnit\Framework\Test $test, Throwable $e, float $time): void must be compatible with PHPUnit\Framework\TestListener::addError(PHPUnit\Framework\Test $test, Exception $e, $time) in /app/vendor/phing/phing/classes/phing/tasks/ext/phpunit/formatter7/PHPUnitResultFormatter7.php on line 29

@siad007
Copy link
Member Author

siad007 commented Oct 8, 2018

@MaXal Can you give us some more info on your phpunit version?

As you can see here https://travis-ci.org/phingofficial/phing/jobs/435082915 phpunit ist of version 7.3.5 and is working fine.

- Installing phpunit/phpunit (7.3.5): Downloading (100%)

@MaXal
Copy link

MaXal commented Oct 8, 2018

We were using PHPUnit 6.5. I've tested now with the 7.3 and all works fine! Thank you and sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
3.0.0-alpha2
Development

Successfully merging this pull request may close these issues.
2 participants
@siad007 @MaXal