Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mkdir] Fixed PHP 8 compat #1629

Merged
merged 1 commit into from
Aug 22, 2021
Merged

[mkdir] Fixed PHP 8 compat #1629

merged 1 commit into from
Aug 22, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Aug 22, 2021

Closes #1619

@siad007 siad007 changed the title Fixed #1619 [mkdir] Fixed PHP 8 compat Aug 22, 2021
@siad007 siad007 self-assigned this Aug 22, 2021
@siad007 siad007 added this to the 3.0.0-RC3 milestone Aug 22, 2021
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1629 (4d226d8) into main (7e6e753) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 4d226d8 differs from pull request most recent head 78d67cf. Consider uploading reports for the commit 78d67cf to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1629      +/-   ##
============================================
- Coverage     57.68%   57.67%   -0.01%     
- Complexity     6932     6934       +2     
============================================
  Files           355      355              
  Lines         16790    16794       +4     
============================================
+ Hits           9685     9686       +1     
- Misses         7105     7108       +3     
Impacted Files Coverage Δ
src/Phing/Io/FileSystem.php 47.16% <50.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6e753...78d67cf. Read the comment docs.

@siad007 siad007 merged commit 924fe09 into phingofficial:main Aug 22, 2021
@siad007 siad007 deleted the Filesystem branch August 22, 2021 10:36
mpdude added a commit to webfactory/phing that referenced this pull request Jan 13, 2022
... in Anlehnung an phingofficial#1629.

Das Problem ist, dass wir keinen Error Handler verwenden, der Errors in Exceptions umwandelt.

Daher der eigene Handler, der den Fehler endgültig still unterschlägt.

Hintergrund: https://php.watch/versions/8.0/fatal-error-suppression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Error with MkdirTask
1 participant