Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ModifiedSelector. #1487

Merged
merged 9 commits into from
Dec 29, 2020
Merged

Added ModifiedSelector. #1487

merged 9 commits into from
Dec 29, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Dec 27, 2020 •
edited
Loading

The <modified> selector computes a value for a file, compares that to the value stored in a cache and select the file, if these two values differ.

@siad007 siad007 added this to the 3.0.0-rc1 milestone Dec 27, 2020
@siad007 siad007 self-assigned this Dec 27, 2020
@codecov
Copy link

codecov bot commented Dec 27, 2020 •
edited
Loading

Codecov Report

Merging #1487 (011d10c) into master (28a3ce7) will increase coverage by 0.26%.
The diff coverage is 75.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1487      +/-   ##
============================================
+ Coverage     53.17%   53.43%   +0.26%     
- Complexity     9166     9276     +110     
============================================
  Files           469      474       +5     
  Lines         22260    22502     +242     
============================================
+ Hits          11837    12025     +188     
- Misses        10423    10477      +54
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/MatchingTask.php 6.66% <0.00%> (-0.16%) 43.00 <1.00> (+1.00) ⬇️
...pes/selectors/modifiedselector/EqualComparator.php 62.50% <62.50%> (ø) 5.00 <5.00> (?)
...selectors/modifiedselector/PropertiesfileCache.php 70.45% <70.45%> (ø) 20.00 <20.00> (?)
...es/selectors/modifiedselector/ModifiedSelector.php 76.96% <76.96%> (ø) 73.00 <73.00> (?)
...s/selectors/modifiedselector/HashfileAlgorithm.php 83.33% <83.33%> (ø) 6.00 <6.00> (?)
...lectors/modifiedselector/LastModifiedAlgorithm.php 88.88% <88.88%> (ø) 4.00 <4.00> (?)
classes/phing/types/selectors/SelectorAware.php 37.28% <100.00%> (+2.20%) 29.00 <1.00> (+1.00)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a3ce7...011d10c. Read the comment docs.

@siad007 siad007 marked this pull request as ready for review December 28, 2020 22:27
@siad007 siad007 merged commit b9357e5 into phingofficial:master Dec 29, 2020
@siad007 siad007 deleted the ModifiedSelector branch December 29, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@siad007 siad007

Labels
core enhancement
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.
1 participant
@siad007