Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoverageMergerTask] Fixed code coverage handling #1437

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Nov 15, 2020

Fixed code coverage in CoverageMerger Task and fixed wrong test assertion to cover empty db entries.
Related to #1430 and phingofficial/task-coverage#2

@siad007 siad007 added this to the 3.0.0-rc1 milestone Nov 15, 2020
@siad007 siad007 self-assigned this Nov 15, 2020
@siad007 siad007 changed the title Fixed code coverage [CoverageMergerTask] Fixed code coverage handling Nov 15, 2020
@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #1437 (3fcece2) into master (823d8f9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1437   +/-   ##
=========================================
  Coverage     54.23%   54.23%           
  Complexity     9134     9134           
=========================================
  Files           467      467           
  Lines         22194    22194           
=========================================
  Hits          12037    12037           
  Misses        10157    10157           
Impacted Files Coverage Δ Complexity Δ
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner8.php 46.72% <0.00%> (ø) 60.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823d8f9...3fcece2. Read the comment docs.

@siad007 siad007 merged commit 5fe2ee7 into phingofficial:master Nov 15, 2020
@siad007 siad007 deleted the FixCodeCoverage branch November 15, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant