ComposerTask tests don't need Composer on the path #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
=========================================
Coverage 54.27% 54.27%
Complexity 9119 9119
=========================================
Files 467 467
Lines 22153 22153
=========================================
Hits 12024 12024
Misses 10129 10129 Continue to review full report at Codecov.
|
siad007
reviewed
Nov 8, 2020
|
|
||
| $pathComposer = $o->getComposer(); | ||
|
|
||
| putenv("PATH=$orgPath"); |
There was a problem hiding this comment.
AFAIK windows uses Path and not PATH 🤔 ?
There was a problem hiding this comment.
Windows isn't case sensitive so Path, PATH, and pAtH would all work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426
Split out testing SetComposer and GetComposer methods. Simulate Composer
existing on the path.