Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualizer bug #1390

Merged
merged 11 commits into from
Sep 10, 2020
Merged

Fix visualizer bug #1390

merged 11 commits into from
Sep 10, 2020

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Sep 5, 2020

Hi, this fixes #1388, I also moved all requirement checking to VisualizerTask::init.

@jawira jawira mentioned this pull request Sep 7, 2020
@siad007 siad007 added this to the 3.0.0-rc1 milestone Sep 10, 2020
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawira LGTM thx

@siad007 siad007 merged commit 038ad1f into phingofficial:master Sep 10, 2020
@jawira jawira deleted the fix-visualizer-bug branch October 14, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

VisualizerTask bug
2 participants