Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phploc] Fixed broken task for PHP >= 7.3 #1387

Merged
merged 3 commits into from
Sep 3, 2020
Merged

[phploc] Fixed broken task for PHP >= 7.3 #1387

merged 3 commits into from
Sep 3, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 3, 2020

  • Enabled test execution under PHP >= 7.3
  • Fixed PHPLoc task error
  • Added json formatter

@siad007 siad007 added this to the 3.0.0-rc1 milestone Sep 3, 2020
siad007 added a commit to phingofficial/guide that referenced this pull request Sep 3, 2020
@siad007
Updated PHPLoc doc
fc1eb1a 
Related to phingofficial/phing#1387
@siad007 siad007 mentioned this pull request Sep 3, 2020
Merged
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #1387 into master will increase coverage by 0.58%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1387      +/-   ##
============================================
+ Coverage     52.48%   53.06%   +0.58%     
- Complexity     9307     9309       +2     
============================================
  Files           476      477       +1     
  Lines         22704    22699       -5     
============================================
+ Hits          11916    12046     +130     
+ Misses        10788    10653     -135
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/phploc/PHPLocTask.php 61.22% <50.00%> (+61.22%) 44.00 <0.00> (ø)
...ses/phing/tasks/ext/phploc/PHPLocJSONFormatter.php 80.00% <80.00%> (ø) 2.00 <2.00> (?)
...ses/phing/tasks/ext/phploc/PHPLocTextFormatter.php 88.88% <85.71%> (+88.88%) 2.00 <0.00> (ø)
.../phing/tasks/ext/phploc/PHPLocFormatterFactory.php 90.90% <100.00%> (+90.90%) 6.00 <0.00> (+1.00)
...sses/phing/tasks/ext/phploc/PHPLocXMLFormatter.php 80.00% <100.00%> (+80.00%) 2.00 <0.00> (-1.00) ⬆️
...sses/phing/tasks/ext/phploc/PHPLocCSVFormatter.php 71.42% <0.00%> (+71.42%) 3.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef28b4...a202b7a. Read the comment docs.

@siad007 siad007 merged commit 8a6a501 into phingofficial:master Sep 3, 2020
@siad007 siad007 deleted the FixedPHPLOC branch September 3, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect enhancement ext tasks PHP compat
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.
1 participant
@siad007