Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhingTask] Added native basedir support. #1295

Merged
merged 2 commits into from
Mar 29, 2020
Merged

[PhingTask] Added native basedir support. #1295

merged 2 commits into from
Mar 29, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 29, 2020

Related to #1241

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1295 into master will decrease coverage by 0.01%.
The diff coverage is 65.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1295      +/-   ##
============================================
- Coverage     51.23%   51.21%   -0.02%     
- Complexity     9294     9302       +8     
============================================
  Files           479      479              
  Lines         22741    22751      +10     
============================================
+ Hits          11651    11652       +1     
- Misses        11090    11099       +9     
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/PhingTask.php 74.23% <65.21%> (-2.94%) 87.00 <10.00> (+8.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd43bab...e6b4c22. Read the comment docs.

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Mar 29, 2020
siad007 added a commit to phingofficial/guide that referenced this pull request Mar 29, 2020
@siad007 siad007 merged commit a7f15e5 into master Mar 29, 2020
@siad007 siad007 deleted the siad007-patch-2 branch March 29, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant