Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter unittests #1176

Merged
merged 20 commits into from
Nov 2, 2019
Merged

Parameter unittests #1176

merged 20 commits into from
Nov 2, 2019

Conversation

kenguest
Copy link
Member

No description provided.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP Fatal error:  Cannot declare class ParameterTest, because the name is already in use in C:\projects\phing\classes\phing\tasks\system\AdhocTask.php(79) : eval()'d code on line 15

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1176 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1176      +/-   ##
============================================
+ Coverage     47.37%   47.41%   +0.04%     
  Complexity     9939     9939              
============================================
  Files           505      505              
  Lines         24414    24414              
============================================
+ Hits          11567    11577      +10     
+ Misses        12847    12837      -10
Impacted Files Coverage Δ Complexity Δ
classes/phing/system/util/RegisterSlot.php 80.95% <0%> (+9.52%) 10% <0%> (ø) ⬇️
classes/phing/types/Parameter.php 91.3% <0%> (+34.78%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacc2ea...d887fd1. Read the comment docs.

@kenguest kenguest requested a review from siad007 October 29, 2019 23:04
@kenguest
Copy link
Member Author

I've renamed the test so it should be ok to merge now.

@siad007 siad007 merged commit 975b919 into phingofficial:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants