Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for Description addText method #1151

Merged
merged 10 commits into from
Oct 6, 2019
Merged

Add unit test for Description addText method #1151

merged 10 commits into from
Oct 6, 2019

Conversation

kenguest
Copy link
Member

@kenguest kenguest commented Oct 6, 2019

addText method doesn't insert spaces when appending text to project description - this unit test will help to spot if this behaviour changes in the future.

@kenguest kenguest requested a review from siad007 October 6, 2019 14:56
@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #1151 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1151      +/-   ##
============================================
+ Coverage     45.71%   45.71%   +<.01%     
  Complexity     9968     9968              
============================================
  Files           505      505              
  Lines         24475    24475              
============================================
+ Hits          11188    11189       +1     
+ Misses        13287    13286       -1
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/Description.php 100% <0%> (+20%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa80a3...4bc2d66. Read the comment docs.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Oct 6, 2019
@siad007 siad007 added the core label Oct 6, 2019
@siad007 siad007 merged commit 9fb8703 into phingofficial:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants