Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some PHP 7.4 specific deprecations. #1127

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Fix some PHP 7.4 specific deprecations. #1127

merged 2 commits into from
Sep 12, 2019

Conversation

kenguest
Copy link
Member

curly brace syntax for accessing array elements and string offsets is deprecated in PHP 7.4.

For example...
curly brace syntax for accessing array elements and string offsets is deprecated in PHP 7.4
found some old-style constructors that needed to be named __construct instead
@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #1127 into master will not change coverage.
The diff coverage is 17.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1127   +/-   ##
=========================================
  Coverage     46.98%   46.98%           
  Complexity     9974     9974           
=========================================
  Files           505      505           
  Lines         24503    24503           
=========================================
  Hits          11513    11513           
  Misses        12990    12990
Impacted Files Coverage Δ Complexity Δ
classes/phing/system/io/WindowsFileSystem.php 3.46% <0%> (ø) 116 <0> (ø) ⬇️
classes/phing/system/io/BufferedReader.php 83.33% <100%> (ø) 21 <0> (ø) ⬇️
classes/phing/util/PathTokenizer.php 59.09% <100%> (ø) 12 <0> (ø) ⬇️
classes/phing/types/Path.php 58.62% <100%> (ø) 68 <0> (ø) ⬇️
classes/phing/PropertyHelper.php 80.58% <100%> (ø) 64 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd9820...2479f2a. Read the comment docs.

@mrook mrook merged commit 7a65bd6 into phingofficial:master Sep 12, 2019
@mrook mrook added this to the 3.0.0-alpha3 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants