Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpCondition] Removed deprecated constant php 7.3 compat #1089

Merged
merged 1 commit into from
Jul 13, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Jul 13, 2019

Fixed deprecated issue on php 7.3 for the HttpCondition.
Related to #1084

@siad007 siad007 added the defect label Jul 13, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Jul 13, 2019
@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #1089 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1089   +/-   ##
=========================================
  Coverage     46.74%   46.74%           
  Complexity    10069    10069           
=========================================
  Files           506      506           
  Lines         24610    24610           
=========================================
  Hits          11504    11504           
  Misses        13106    13106
Impacted Files Coverage Δ Complexity Δ
...ses/phing/tasks/system/condition/HttpCondition.php 0% <0%> (ø) 14 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdf8e4...a8e00dc. Read the comment docs.

@siad007 siad007 merged commit 3e0763d into master Jul 13, 2019
@siad007 siad007 deleted the siad007-patch-1 branch July 13, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant