Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed phing test execution under PHPUnit 8 #1024

Merged
merged 47 commits into from
Feb 4, 2019
Merged

Fixed phing test execution under PHPUnit 8 #1024

merged 47 commits into from
Feb 4, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 3, 2019 •
edited
Loading

Related to #1021

  • rewrite of the travis build file for composer prefer-lowest
  • PHP 7.1 tests with PHPUnit 7.x
  • PHP > 7.1 tests with PHPUnit 8
  • PHP 7.3 builds are now mandatory
  • Added a code analysis stage to travis to check against phpcs
  • Fixed all phpcs errors

@siad007 siad007 added the defect label Feb 3, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Feb 3, 2019
@codecov
Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #1024 into master will decrease coverage by 0.35%.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1024      +/-   ##
============================================
- Coverage     45.82%   45.47%   -0.36%     
- Complexity     9970    10029      +59     
============================================
  Files           504      505       +1     
  Lines         24116    24180      +64     
============================================
- Hits          11052    10995      -57     
- Misses        13064    13185     +121
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/phpunit/PHPUnitTask.php 41.7% <100%> (-0.38%) 101 <0> (+2)
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner8.php 45.21% <45.21%> (ø) 57 <57> (?)
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner7.php 0% <0%> (-58.12%) 57% <0%> (ø)
...sses/phing/tasks/system/condition/AndCondition.php 83.33% <0%> (-16.67%) 3% <0%> (ø)
classes/phing/system/io/FileParserFactory.php 75% <0%> (-6.82%) 4% <0%> (ø)
classes/phing/tasks/system/MoveTask.php 65.3% <0%> (-4.09%) 40% <0%> (ø)
classes/phing/filters/ReplaceRegexp.php 92.3% <0%> (-3.85%) 8% <0%> (ø)
classes/phing/tasks/system/AppendTask.php 77.63% <0%> (-1.99%) 79% <0%> (ø)
classes/phing/tasks/system/DeleteTask.php 56.8% <0%> (-1.61%) 68% <0%> (ø)
classes/phing/util/SourceFileScanner.php 62.31% <0%> (-1.45%) 21% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bc3ef...19a492d. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 3, 2019 •
edited
Loading

Codecov Report

Merging #1024 into master will decrease coverage by 0.23%.
The diff coverage is 28.99%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1024      +/-   ##
============================================
- Coverage     45.82%   45.59%   -0.24%     
- Complexity     9970    10029      +59     
============================================
  Files           504      505       +1     
  Lines         24116    24460     +344     
============================================
+ Hits          11052    11152     +100     
- Misses        13064    13308     +244
Impacted Files Coverage Δ Complexity Δ
...g/tasks/ext/PhpCodeSnifferTaskFormatterElement.php 70.58% <ø> (ø) 10 <0> (?)
classes/phing/tasks/ext/pdo/PDOQuerySplitter.php 100% <ø> (ø) 1 <0> (ø) ⬇️
classes/phing/listener/statistics/SeriesTimer.php 0% <ø> (ø) 6 <0> (ø) ⬇️
classes/phing/mappers/CutDirsMapper.php 92.85% <ø> (ø) 7 <0> (ø) ⬇️
classes/phing/tasks/ext/git/GitDescribeTask.php 65.33% <ø> (ø) 32 <0> (ø) ⬇️
classes/phing/tasks/ext/PearPkgRole.php 0% <ø> (ø) 4 <0> (ø) ⬇️
classes/phing/listener/SilentLogger.php 0% <ø> (ø) 7 <0> (ø) ⬇️
classes/phing/BuildEvent.php 84.37% <ø> (ø) 12 <0> (ø) ⬇️
classes/phing/tasks/ext/PearPkgMappingElement.php 0% <ø> (ø) 8 <0> (ø) ⬇️
classes/phing/mappers/ChainedMapper.php 100% <ø> (ø) 6 <0> (ø) ⬇️
... and 418 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bc3ef...f106ce1. Read the comment docs.

@siad007 siad007 changed the title [WIP] PHPUnit8 support Fixed phing test execution under PHPUnit 8 Feb 4, 2019
@siad007 siad007 merged commit 2c23749 into phingofficial:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect
Milestone
3.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
1 participant
@siad007