Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PatchTask extensions #1023

Merged
merged 17 commits into from
Feb 3, 2019
Merged

PatchTask extensions #1023

merged 17 commits into from
Feb 3, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 2, 2019 •
edited
Loading

  • Added forward and fuzz attributes
  • Added tests and docu
  • Updated relax file
  • Reduced code duplication and increased code coverage

@codecov
Copy link

codecov bot commented Feb 2, 2019 •
edited
Loading

Codecov Report

Merging #1023 into master will increase coverage by 0.39%.
The diff coverage is 52.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1023      +/-   ##
============================================
+ Coverage     45.43%   45.82%   +0.39%     
+ Complexity     9991     9970      -21     
============================================
  Files           503      504       +1     
  Lines         24199    24116      -83     
============================================
+ Hits          10994    11052      +58     
+ Misses        13205    13064     -141
Impacted Files Coverage Δ Complexity Δ
classes/phing/filters/ExpandProperties.php 100% <ø> (+60.71%) 3 <0> (-6) ⬇️
classes/phing/tasks/ext/FtpDeployTask.php 0% <ø> (ø) 64 <0> (-6) ⬇️
classes/phing/types/DirSet.php 100% <ø> (+100%) 1 <0> (ø) ⬇️
classes/phing/tasks/ext/PhpLintTask.php 71.42% <ø> (+12.02%) 40 <0> (-6) ⬇️
classes/phing/tasks/ext/ssh/ScpTask.php 0% <ø> (ø) 55 <0> (-6) ⬇️
...asses/phing/tasks/system/element/LogLevelAware.php 0% <0%> (ø) 6 <6> (?)
classes/phing/tasks/system/PhpEvalTask.php 34.84% <100%> (+8.92%) 32 <1> (-5) ⬇️
classes/phing/tasks/system/ForeachTask.php 68.78% <100%> (-0.71%) 56 <7> (-5)
classes/phing/types/FilterChain.php 45.58% <44%> (+2.89%) 32 <1> (+1) ⬆️
classes/phing/tasks/ext/PatchTask.php 54.41% <60.71%> (+54.41%) 30 <12> (+3) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5680e8...2e70cf4. Read the comment docs.

@siad007 siad007 changed the title [WIP] Reduced code duplications PatchTask extensions Feb 3, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Feb 3, 2019
@siad007 siad007 merged commit 08bc3ef into phingofficial:master Feb 3, 2019
@siad007 siad007 deleted the RemoveNotNeededStuff branch February 3, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
3.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
1 participant
@siad007