Dynamic path for composer task #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrook
requested changes
Mar 24, 2017
|
Related to #558. |
|
Would it be a good idea to implement a try catch on the command with the provided composer path and then try finding a path if that fails? That would cover the user entering a wrong path. But then the user would not be aware of that mistake. |
|
I moved the path check to the getComposer function and cleaned up the class a bit. |
added 18 commits
March 24, 2017 14:01
|
Mind giving me a new review @mrook ? |
|
Can you squash the commits? The PR is a little noisy this way :) Anyway:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be a nice feature to have the phing composer task check if a composer installation is available to execute the command with if no composer executable path is set.