This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
48 allow explicit timer start #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having trouble understanding the sense, since it only captures the duration why should there be an external time to mess with the inner working of the |
|
This supports the use case where the transaction is considered to have started before the Timer object is created. I believe this is the reason the Laravel module uses LARAVEL_START when calculating the duration: https://github.com/philkra/elastic-apm-laravel/blob/master/src/Middleware/RecordTransaction.php#L64 Allowing the Timer to accept a start time would allow it to be used in such cases for getElapsed and getDuration. |
|
I moved the discussion to philkra/elastic-apm-laravel#33 |
philkra
suggested changes
Feb 21, 2019
|
It seems like we are in general agreement on the changes, so I've removed the draft status on this PR. |
philkra
approved these changes
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR so we can discuss this proposed change.
The change I need here is in support of changes in the Laravel package which uses these classes. Specifically, I want to use a Timer object but I must be able to set a start time rather than having the timer start when created. That isolated change is pretty easy and seems save.
At the same time, it makes sense to expose that capability through the existing Timer creational methods, which means updating the EventFactoryInterface, Transaction and Agent classes. The start time parameter is optional and safely defaults to
nullso should have no impact on existing use cases.Any subclasses of the EventFactoryInterface will need to update the createTransaction method signature however.
I believe this change makes the Timer class usable in more circumstances without compromising current behavior.