-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing link hints when "aria-hidden=true" #3501
Comments
For whoever is interested in this, here's code analysis:
What Vimium C does now: its master branch now skips an |
Why does Vimium exclude (In my own extension, Link Hints, I don’t care about |
According to specification https://www.w3.org/TR/using-aria/#fourth , |
Great discussion everyone, thanks for the help. So there are two proposals: hint elements with aria-hidden=true, or mimic Vimium C's more complex change (commit). I'm inclined to just start ignoring aria-hidden because it's a simple and understandable strategy, and leans towards false positives rather than false negatives, as @gnarendran suggests. @gdh1995, is there a prominent case that motivated you to implement the more sophisticated "cover detection" logic? I tried this out in #3505 (take it for a spin) and the guardian and google news are much more usable now. |
Um, it's just because I didn't what it would be if |
@philc I tried #3505 and it seems good (didn't notice any missing hint) when used on guardian.co.uk and news.google.com. There are slight differences from 1.64.6 like some hints being positioned at any given link's image (if present) rather than its text, but I guess one will get used to it! Thanks a lot for looking into this. Regards. |
Closing this now that I've merged #3505. Feel free to resume discussion if you find undesirable effects. Thanks everyone! |
After the merge of "Adds new check to see if an element is covered by another #2251" in 1.65, hints for links with "aria-hidden=true" became inconsistent/unpredictable. This issue was not present in 1.64.6. This has been already discussed: #3486 (comment) (https://www.theguardian.com/uk) and #3474 (comment) (https://news.google.com/?hl=en-IN&gl=IN&ceid=IN:en). But since those PR/pull have been closed/merged, opening this new PR as a place holder.
(Also this issue is different from #3492 and #3493, though the same merge caused them as well.)
Typically I use vimium as follows: See an interesting link X and press f to generate its link hint. It is ok to me if there are redundant/unclickable hints generated for other links, as long as the hint is generated for X, as I am going to anyway ignore others. But it would be disappointing if unpredictably hint is not generated for X. In other words, it would be nice if vimium errs on the side of generating some redundant links hints rather than on the side of ignoring some useful links.
@gdh1995 has commented on it and seems to already have some fixes for vimium-c for this issue (though I am not sure!). Meanwhile I am taking the easy way out by cloning vimium and locally reverting the commits 4d39729 and caf13c2, so that vimium works seamlessly again. Regards.
The text was updated successfully, but these errors were encountered: