-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify phasor_from_signal functions #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent @cgohlke! I think this improves the clarity of phasor_from_signal
and simplifies the workflow. It all looks good to me (just some minor comments that can be disregarded).
Also I think this is much better than before, so they are not considered for averaging, filtering, etc. |
One issue I noticed is that the function returns scalar values as Python |
Description
This PR merges the
phasor_from_signal
andphasor_from_signal_fft
functions into one:phasor_from_signal_fft
function.phasor_from_signal
:use_fft
andrfft
(used to berfft_func
). By default, FFT is automatically used when all or at least 8 harmonics are calculated, or arfft
function is specified.irfft_func
parameter toirfft
inphasor_to_signal
.NaN
orInf
instead of 0.0 in case of zero DC.The introduction tutorial is currently failing due to #96 and #97
Release note
Summarize the changes in the code block below to be included in the
release notes:
Checklist