Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes several additions/changes to the
phasor
and_phasorpy.pyx
modules:lifetime_to_signal
function, which generates time/frequency-domain decay/waveforms from specified lifetimes. The signals are convoluted with an instrument response function. Closes Add a lifetime calculator module #6phasor_to_complex
,phasor_multiply
, andphasor_divide
helper functions (originally proposed in Add phasor_to_complex, phasor_multiply, and phasor_divide helper functions #92)._phasorpy.pyx
:_gaussian_signal
,_phasor_multiply
, and_phasor_divide
.phasor_
,polar_
, andlifetime_
:frequency_from_lifetime
->lifetime_to_frequency
frequency_to_lifetime
->lifetime_from_frequency
fraction_from_amplitude
->lifetime_fraction_from_amplitude
fraction_to_amplitude
->lifetime_fraction_to_amplitude
phasor_transform
from "calibration" to "transformation" together withphasor_multiply
andphasor_divide
in the module docstring. Is that reasonable?Release note
Summarize the changes in the code block below to be included in the
release notes:
Checklist