Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LFD workshop FLIM tutorial #63

Merged
merged 20 commits into from
Aug 5, 2024
Merged

Conversation

cgohlke
Copy link
Member

@cgohlke cgohlke commented Apr 29, 2024

Description

This tutorial is a close adaptation of the LFD Workshop computer training tutorial - FLIM section (by E. Gratton, M. Digman, and J. Unruh) using the PhasorPy library instead of the Globals for Images · SimFCS and Excel software.

I was curious how much of the original tutorial could be implemented using the current state of the PhasorPy library.

The following functionality is still missing from PhasorPy to finish the tutorial:

Release note

Summarize the changes in the code block below to be included in the
release notes:

Add LFD workshop FLIM tutorial

Checklist

  • The pull request title, summary, and description are concise.
  • Related issues are linked in the description.
  • New dependencies are explained.
  • The source code and documentation can be distributed under the MIT license.
  • The source code adheres to code standards.
  • New classes, functions, and features are thoroughly tested.
  • New, user-facing classes, functions, and features are documented.
  • New features are covered in tutorials.
  • No files other than source code, documentation, and project settings are added to the repository.

@cgohlke cgohlke added the documentation Improvements or additions to documentation label Apr 29, 2024
@cgohlke cgohlke self-assigned this Apr 29, 2024
@bruno-pannunzio
Copy link
Contributor

Excelent idea Christoph! This is very useful to see what vital aspects of the library are we missing. We can discuss today, but I think this is a very good starting point to think how to approach this missing functionalities and plan the next steps.

@lmalacrida
Copy link

Sounds very good and important. I will be happy to collaborate in testing and running the tutorial

@cgohlke
Copy link
Member Author

cgohlke commented Apr 30, 2024

A HTML version of the tutorial is available in the artifact of the "Deploy documentation" checks. Extract all the files in the archive to a directory and open index.html with a web browser. Then browse to Tutorials -> LFD Workshop FLIM Tutorial.

@cgohlke cgohlke changed the title WIP: Add LFD workshop FLIM tutorial Add LFD workshop FLIM tutorial Aug 4, 2024
@cgohlke
Copy link
Member Author

cgohlke commented Aug 4, 2024

Could this PR be merged so it can be updated while adding new features in other PRs?

Copy link
Contributor

@bruno-pannunzio bruno-pannunzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @cgohlke, this can be merged so we can have it available and keep working on it as we keep implementing the missing features.

@cgohlke cgohlke merged commit efb44ff into phasorpy:main Aug 5, 2024
16 checks passed
@cgohlke cgohlke deleted the lfd_workshop_tutorial branch August 5, 2024 14:43
schutyb pushed a commit to schutyb/phasorpy that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants