Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to convert between lifetime fractions and amplitudes #60

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

cgohlke
Copy link
Member

@cgohlke cgohlke commented Apr 24, 2024

Description

Add two helper functions to the phasor module to convert between lifetime fractional intensities and pre-exponential amplitudes. These functions will probably be moved to a lifetime module at some point.

Also rename the Cython extension module from _phasor to _phasorpy since it will contain functions not related to the phasor module.

Release note

Summarize the changes in the code block below to be included in the
release notes:

Add functions to convert between lifetime fractions and amplitudes

Checklist

  • The pull request title, summary, and description are concise.
  • Related issues are linked in the description.
  • New dependencies are explained.
  • The source code and documentation can be distributed under the MIT license.
  • The source code adheres to code standards.
  • New classes, functions, and features are thoroughly tested.
  • New, user-facing classes, functions, and features are documented.
  • New features are covered in tutorials.
  • No files other than source code, documentation, and project settings are added to the repository.

@cgohlke cgohlke added the enhancement New feature or request label Apr 24, 2024
@cgohlke cgohlke requested a review from bruno-pannunzio April 24, 2024 17:46
@cgohlke cgohlke self-assigned this Apr 24, 2024
Copy link
Contributor

@bruno-pannunzio bruno-pannunzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @cgohlke. Maybe when the components tutorial is ready, we can add some use examples for converting to and from amplitude.

@cgohlke
Copy link
Member Author

cgohlke commented Apr 24, 2024

I'm working on porting the LFD Workshop FLIM Tutorial to the PhasorPy library. It requires the fraction_from_amplitude function. That's why I did not add it to another tutorial here...

@cgohlke cgohlke merged commit bca0296 into phasorpy:main Apr 24, 2024
13 checks passed
@cgohlke cgohlke deleted the fraction_amplitude branch April 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants